Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML export to Python SDK #782

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Conversation

woop
Copy link
Member

@woop woop commented Jun 7, 2020

What this PR does / why we need it:

This PR allows users to export feature sets to YAML strings. Usage is as follows

fs = FeatureSet("my_feature_set")
print(fs.to_yaml())

Does this PR introduce a user-facing change?:

Adds the ability to export a feature set to YAML.

@pyalex
Copy link
Collaborator

pyalex commented Jun 8, 2020

/approve

@pyalex
Copy link
Collaborator

pyalex commented Jun 8, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 561d6f4 into feast-dev:master Jun 8, 2020
zhangchi1 pushed a commit to Cimpress-MCP/feast that referenced this pull request Jun 11, 2020
* Add feature set export method

* Fix equality in feature set and remove YAML path export

* Remove spec from yaml export

* Conditionally delete meta from feature set when empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants