Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users compute statistics over retrieved batch datasets #799

Merged
merged 6 commits into from
Jun 23, 2020

Conversation

zhilingc
Copy link
Collaborator

What this PR does / why we need it:
This PR adds the functionality to allow users to optionally compute tfdv statistics over retrieved batch datasets:

# compute_statistics defaults to false. If false, statistics() will always return an empty object.
dataset = client.get_batch_features(feature_refs, entity_rows, compute_statistics=True)
# waits for retrieval job to be complete, then returns tfdv statistics
stats = dataset.statistics()

Like with the feature set statistics, these statstics can then be fed into tfdv for validation, or facets to explore the dataset.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

- Adds the parameter compute_statistics to client.get_batch_statistics()
- Adds the method statistics() which returns statistics from retrieval job

@zhilingc
Copy link
Collaborator Author

/test test-end-to-end-batch

@zhilingc
Copy link
Collaborator Author

/test test-end-to-end-batch

1 similar comment
@zhilingc
Copy link
Collaborator Author

/test test-end-to-end-batch

@zhilingc zhilingc force-pushed the retrieval-stats branch 2 times, most recently from f404741 to e8ae893 Compare June 23, 2020 03:46
@zhilingc
Copy link
Collaborator Author

/test test-end-to-end-batch

@zhilingc
Copy link
Collaborator Author

/test test-end-to-end-redis-cluster

@woop
Copy link
Member

woop commented Jun 23, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 23, 2020

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Jun 23, 2020
@feast-ci-bot feast-ci-bot merged commit 8c2201c into feast-dev:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants