Allow registration of feature without warehouse store #80
Conversation
|
That's to avoid NPE
…On Thu, 17 Jan 2019, 12:46 Chen Zhiling ***@***.*** wrote:
***@***.**** requested changes on this pull request.
------------------------------
In core/src/main/java/feast/core/validators/SpecValidator.java
<#80 (comment)>:
> @@ -138,13 +140,17 @@ public void validateFeatureSpec(FeatureSpec spec) throws IllegalArgumentExceptio
checkArgument(
Arrays.asList(SUPPORTED_SERVING_STORES).contains(servingStore.get().getType()),
Strings.lenientFormat("Unsupported serving store type", servingStore.get().getType()));
- checkArgument(
- warehouseStore.isPresent(),
- Strings.lenientFormat("Warehouse store with id %s does not exist", warehouseStoreId));
- checkArgument(
- Arrays.asList(SUPPORTED_WAREHOUSE_STORES).contains(warehouseStore.get().getType()),
- Strings.lenientFormat(
- "Unsupported warehouse store type", warehouseStore.get().getType()));
+
+ if (!NO_STORE.equals(warehouseStoreId)) {
should this be the other way around? !warehouseStoreId.equals(NO_STORE)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD1i5_KAMI-V3Nko6wOthn09jkXOaQ_Mks5vEAA3gaJpZM4aEa7O>
.
|
Don't |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Adapted custom code for upstream changes in release 0.6.0: - FeatureSets are delivered to Ingestion Job through Kafka (feast-dev#792) - Closes KE-982 (*Spark job fails when too many featureset are provided in the JSON parameter*) - Enable isort for Python SDK 843 - Enable linting and formatting for e2e tests 832 - Cleaned up Python SDK code for downloading files vs. directories
Fix #5