Bugfix: Re-applying of featuresets does not update label changes #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
pyalex
reviewed
Jul 2, 2020
| * | ||
| * @param featureSpec {@link FeatureSpec} containing schema changes. | ||
| */ | ||
| public void updateFromProto(FeatureSpec featureSpec) { | ||
| this.setLabels(TypeConversion.convertMapToJsonString(featureSpec.getLabelsMap())); |
There was a problem hiding this comment.
shouldn't we apply update after isArchived check?
pyalex
reviewed
Jul 2, 2020
| @@ -314,9 +314,10 @@ public void updateFromProto(FeatureSetProto.FeatureSet featureSetProto) | |||
| spec.getEntitiesList(), existingEntities)); | |||
| } | |||
|
|
|||
| // 4. Update max age and source. | |||
| // 4. Update max age, source and labels. | |||
| maxAgeSeconds = spec.getMaxAge().getSeconds(); | |||
There was a problem hiding this comment.
could please add this. here as well
There was a problem hiding this comment.
adding for source as well.
pyalex
reviewed
Jul 2, 2020
| @@ -314,9 +314,10 @@ public void updateFromProto(FeatureSetProto.FeatureSet featureSetProto) | |||
| spec.getEntitiesList(), existingEntities)); | |||
| } | |||
|
|
|||
| // 4. Update max age and source. | |||
| // 4. Update max age, source and labels. | |||
There was a problem hiding this comment.
looks like numbering is broken. should be 2.
|
/retest |
2 similar comments
|
/retest |
|
/retest |
pyalex
approved these changes
Jul 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, when we reapply featuresets to add/remove labels from featureset or features, the changes made to labels are not propagated.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: