-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Authentication and Authorization for feast serving #865
Conversation
Hi @jmelinav. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
auth/src/main/java/feast/auth/service/AuthorizationService.java
Outdated
Show resolved
Hide resolved
/assign @pyalex |
/lgtm |
/ok-to-test |
/test test-end-to-end-auth |
/test test-end-to-end-batch |
2eb7b2c
to
21a2f7d
Compare
/test test-end-to-end-auth |
/test test-end-to-end-batch-dataflow |
…, removed unwanted expire time validation from gauth.
dd1d141
to
59bf780
Compare
serving/src/test/java/feast/serving/it/ServingServiceOauthAuthroizationIT.java
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dr3s, jmelinav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test-end-to-end |
/retest |
/test test-end-to-end-batch-dataflow |
/lgtm |
New changes are detected. LGTM label has been removed. |
@jmelinav: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test test-end-to-end-redis-cluster |
* Authentication and authorization for feast serving, squashed on 07/21 * fix e2e, add metadata plugin in jobs, merge labels, auth failure test, removed unwanted expire time validation from gauth. * fix rebase adaption. * Fix core integration test. * Authentication integration test. * Add authorization test and minor refactoring. * fix failing integration test. * fix lint error.
What this PR does / why we need it:
PR enables authentication and authorization for feast serving, configurations remain same as feast core's authentication and authorization configuration.
Which issue(s) this PR fixes:
Fixes #823
Does this PR introduce a user-facing change?:Yes