Restart Ingestion Job on code version update #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
reviewed
Aug 14, 2020
| this.blacklistedStores = feastProperties.getJobs().getCoordinator().getBlacklistedStores(); | ||
| this.currentVersion = feastProperties.getVersion(); | ||
| this.jobLabels = new HashMap<>(feastProperties.getJobs().getCoordinator().getJobSelector()); | ||
| this.jobLabels.put("version", this.currentVersion); |
There was a problem hiding this comment.
should this.currentVersion be a getter?
There was a problem hiding this comment.
this is private final property, not sure how getter could be useful?
pyalex
force-pushed
the
restart-on-version
branch
2 times, most recently
from
bf8d785
to
f5e5a9e
Compare
pyalex
force-pushed
the
restart-on-version
branch
from
f5e5a9e
to
631bff1
Compare
|
/test test-end-to-end |
pyalex
force-pushed
the
restart-on-version
branch
from
edbeea8
to
209a65d
Compare
|
/test test-end-to-end-batch |
|
/lgtm |
woop
approved these changes
Aug 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zhangchi1
pushed a commit
to Cimpress-MCP/feast
that referenced
this pull request
Aug 19, 2020
* blacklist -> whitelist * add whitelisted property * coordinator properties in e2e tests * move labels to job & jobcoordinator * it test for version update * version label constant * fix version label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Each Job can have individual labels that are being merged with common labels (see
feast.jobs.runners.options.labels) before job created. Job labels are being generated & managed byJobCoordinator. Currently labels consists offeast.job.coordinator.jobSelectorand feast version. Job labels overwrite common labels for the same keys.Added label
feast_versionthat keeps version of feast code attached to the job. As soon as new version is being released - JobCoordinator automatically restarts jobs with older version in this label.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: