Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #953

Merged
merged 16 commits into from
Aug 25, 2020
Merged

Fix flaky tests #953

merged 16 commits into from
Aug 25, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Aug 21, 2020

What this PR does / why we need it:
Some refactoring / bug fixes to make tests more stable:

  1. Use testcontainers in ingestion unit-tests
  2. Better isolation for e2e tests
  3. Fix rounding error in timestamp for batch tests
  4. Fix Segmentation Fault occurring in Python SDK
  5. Dynamic port allocation in python SDK unit tests

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test test-end-to-end-redis-cluster

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test test-end-to-end

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test all

1 similar comment
@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test test-end-to-end-auth

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test test-end-to-end-batch

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test all

3 similar comments
@pyalex
Copy link
Collaborator Author

pyalex commented Aug 21, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 23, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 23, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test all

3 similar comments
@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test all

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test all

@pyalex pyalex changed the title [WIP] Fix flaky tests Fix flaky tests Aug 24, 2020
@pyalex
Copy link
Collaborator Author

pyalex commented Aug 25, 2020

/test test-end-to-end-batch-dataflow

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 25, 2020

/retest

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Aug 25, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 6b7a844 into feast-dev:master Aug 25, 2020
@pyalex pyalex deleted the flaky-tests branch November 30, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants