Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent historical retrieval from failing on dash in project / featureSet name #970

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Sep 1, 2020

What this PR does / why we need it:
When project name or feature-set name contains "-" invalid query will be built on historical retrieval.

{
 "code" : 400,
 "errors" : [ {
    "domain" : "global",
    "location" : "q",
    "locationType" : "parameter",
    "message" : "Syntax error: Expected \")\" but got \"-\" at [16:13]",
    "reason" : "invalidQuery"
 } ],
 "message" : "Syntax error: Expected \")\" but got \"-\" at [16:13]",
 "status" : "INVALID_ARGUMENT"
}

And since there's no mechanism to propagate this error to the user

client.get_historical_features(...).to_dataframe()

will hang.

Replaces - with _ in project and feature set name when interacting with BQ.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

@pyalex: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-batch-dataflow adf2798 link /test test-end-to-end-batch-dataflow

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex pyalex merged commit 1794357 into feast-dev:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants