Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chunk data serialization workaround in feather-anvil #272

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Remove chunk data serialization workaround in feather-anvil #272

merged 2 commits into from
Jun 28, 2020

Conversation

Schuwi
Copy link
Member

@Schuwi Schuwi commented Jun 23, 2020

Because serde derived serialization of the NBT Byte/Int/LongArray type was previously impossible via hematite_nbt, a workaround was in place, implementing serialization manually via the non-serde hematite_nbt API.
Now that serde serialization support is implemented via PistonDevelopers/hematite_nbt#52 this PR seeks to remove the manual serialization and use serde derive macros in feather-anvil instead. This removes a lot of verbose code and makes improving the data model way faster and less error-prone.

I tested loading, flying around in and saving of a vanilla world. No errors occured and everything seemed to be fine though I haven't inspected the NBT files. All tests complete successfully.

This ties in with my work on world loading problems in #269.

@Schuwi
Copy link
Member Author

Schuwi commented Jun 26, 2020

Weeeell, today I've learnt to be nice to clippy, and run it with --all-targets. It... tends to help 😅

Copy link
Member

@caelunshun caelunshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and I'm sorry about the delay! Great work on getting rid of that NBT workaround.

@caelunshun caelunshun merged commit e692704 into feather-rs:develop Jun 28, 2020
@Schuwi Schuwi deleted the anvil-serde-serialization branch July 15, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants