Remove chunk data serialization workaround in feather-anvil #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because serde derived serialization of the NBT Byte/Int/LongArray type was previously impossible via
hematite_nbt
, a workaround was in place, implementing serialization manually via the non-serdehematite_nbt
API.Now that serde serialization support is implemented via PistonDevelopers/hematite_nbt#52 this PR seeks to remove the manual serialization and use serde derive macros in
feather-anvil
instead. This removes a lot of verbose code and makes improving the data model way faster and less error-prone.I tested loading, flying around in and saving of a vanilla world. No errors occured and everything seemed to be fine though I haven't inspected the NBT files. All tests complete successfully.
This ties in with my work on world loading problems in #269.