Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request: Facebook Messenger #429

Open
plebot opened this issue May 18, 2018 · 10 comments · May be fixed by #650
Open

Icon request: Facebook Messenger #429

plebot opened this issue May 18, 2018 · 10 comments · May be fixed by #650

Comments

@plebot
Copy link

plebot commented May 18, 2018

Icon name : Messenger
Use case : Link/Button « Share on Messenger »
Screenshot :
image

@jletey
Copy link

jletey commented Jun 23, 2019

@colebemis @locness3 @plebot What do you think of this? I know that the last one (the filled in one) probably doesn't follow #171 and probably also the middle one ... we'll see what you guys say!

@moeenio
Copy link

moeenio commented Jun 24, 2019

@colebemis @locness3 @plebot What do you think of this? I know that the last one (the filled in one) probably doesn't follow #171 and probably also the middle one ... we'll see what you guys say!

Guidelines are clear : "No fills".

@moeenio
Copy link

moeenio commented Jun 24, 2019

That is great, but again, please don't outline.

@jletey
Copy link

jletey commented Jun 24, 2019

@locness3 What "fills" are you talking about? In the first one (which is my personal favorite), everything is outlined!

@moeenio
Copy link

moeenio commented Jun 25, 2019

@locness3 What "fills" are you talking about? In the first one (which is my personal favorite), everything is outlined!

Sorry, I was unclear, I talked about the filled one.

@jletey
Copy link

jletey commented Jun 25, 2019

@locness3 So what about the non-filled one? I'm going to change to a 2px center instead of an outline

@jletey
Copy link

jletey commented Jul 2, 2019

@locness3 How does it look now? Unfortunately, a 24x24 px space isn't big enough to make the lightning an outline (which would make the icon look even better) 😞!

Screen Shot 2019-07-02 at 8 04 58 AM

@moeenio
Copy link

moeenio commented Jul 2, 2019

@locness3 How does it look now? Unfortunately, a 24x24 px space isn't big enough to make the lightning an outline (which would make the icon look even better) 😞!

Screen Shot 2019-07-02 at 8 04 58 AM

Great

@jletey
Copy link

jletey commented Jul 2, 2019

@locness3 How does it look now? Unfortunately, a 24x24 px space isn't big enough to make the lightning an outline (which would make the icon look even better) 😞!
Screen Shot 2019-07-02 at 8 04 58 AM

Great

@locness3 Wonderful ... submitting a PR now!

jletey added a commit to jletey/feather that referenced this issue Jul 2, 2019
@jletey jletey linked a pull request Jul 2, 2019 that will close this issue
@MarcelloTheArcane
Copy link
Contributor

See #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants