Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request: sum #86

Open
alexantr opened this issue Jun 6, 2017 · 17 comments · May be fixed by #660
Open

Icon request: sum #86

alexantr opened this issue Jun 6, 2017 · 17 comments · May be fixed by #660

Comments

@alexantr
Copy link

alexantr commented Jun 6, 2017

Sum icon for total count.
Example:

sum-sign

@jletey
Copy link

jletey commented Jul 2, 2019

@locness3 @colebemis @alexantr How does this look?

Screen Shot 2019-07-02 at 7 49 34 AM

@locness3
Copy link

locness3 commented Jul 2, 2019

Great

@locness3
Copy link

locness3 commented Jul 2, 2019

Maybe work on the "optical volume" #171, it seems a bit close to the canvas limits.

@jletey
Copy link

jletey commented Jul 2, 2019

@locness3 Something more like this?

Screen Shot 2019-07-02 at 3 14 51 PM

@locness3
Copy link

locness3 commented Jul 2, 2019

Yes, perfect!

@locness3
Copy link

locness3 commented Jul 2, 2019

Could you try a side-by-side with other icons though ?

@jletey
Copy link

jletey commented Jul 2, 2019

Could you try a side-by-side with other icons though ?

Not exactly quite sure how to do that @locness3 ... I've seen people comment about using Chrome Devtools to put the icon into feathericons.com, but I'm not quite sure how to do that!

@locness3
Copy link

locness3 commented Jul 3, 2019

Just download some svgs from feathericons.com and put them side-by-side with your icon in Figma.

@jletey
Copy link

jletey commented Jul 3, 2019

@locness3

Screen Shot 2019-07-03 at 9 45 41 AM

@locness3
Copy link

locness3 commented Jul 3, 2019

Maybe comparing with maths icons, and circle/rectangle ?

@jletey
Copy link

jletey commented Jul 3, 2019

There doesn't exist any maths icons in Feather @locness3

@locness3
Copy link

locness3 commented Jul 3, 2019

plus and minus ?

@jletey
Copy link

jletey commented Jul 3, 2019

@locness3

Screen Shot 2019-07-03 at 2 30 15 PM

The sum icon is of the same height as the plus icon ... can change the width so that it's the same width as the plus and minus icons!

@locness3
Copy link

locness3 commented Jul 3, 2019

can change the width so that it's the same width as the plus and minus icons!

I think that's not necessary

@jletey
Copy link

jletey commented Jul 3, 2019

@locness3 Okay ... so is it good to submit?

@locness3
Copy link

locness3 commented Jul 3, 2019

yes i think

@jletey
Copy link

jletey commented Jul 3, 2019

awesome ... opening a PR!

jletey added a commit to jletey/feather that referenced this issue Jul 3, 2019
@jletey jletey linked a pull request Jul 3, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants