Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created an icon for X (the new Twitter logo) #1208

Closed
wants to merge 5 commits into from
Closed

Created an icon for X (the new Twitter logo) #1208

wants to merge 5 commits into from

Conversation

Exetric
Copy link

@Exetric Exetric commented Jul 26, 2023

I made this for my personal website and thought I might contribute it to the project because I made it to be the same style.

@zarazinsfuss
Copy link

This would implement Issue #1207:
Icon Request: Twitter ⇒ 𝕏

@zarazinsfuss zarazinsfuss mentioned this pull request Aug 3, 2023
Open
zarazinsfuss
zarazinsfuss reviewed Aug 3, 2023
View reviewed changes
Copy link

@zarazinsfuss zarazinsfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Looks in line with the feather aesthetic.

@terrablue
Copy link

Hi, is this icon not smaller when compared to the others?

x-icon

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 26a0a42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Exetric
Copy link
Author

Exetric commented Aug 24, 2023

Hi, is this icon not smaller when compared to the others?

x-icon

Thanks for showing me this I didn't notice, I just updated the icon to fix this so it should be good

@Exetric
Copy link
Author

Exetric commented Aug 24, 2023 •
edited
Loading

image

Here's a quick mockup to show how it would fit in

@terrablue
Copy link

Works for me, thanks.

@ryandotfurrer
Copy link

Bumping this for PR review - would love to use this!

@karsa-mistmere
Copy link

Brand icons are deprecated: #763

I'm sorry to say that this PR will almost certainly never ever get merged.

@ryandotfurrer
Copy link

Brand icons are deprecated: #763

I'm sorry to say that this PR will almost certainly never ever get merged.

Damn, that's a bummer.
Thanks for letting me know.

@NicolaCocozza
Copy link

Any news?

@yurist38
Copy link

yurist38 commented Mar 2, 2024 •
edited
Loading

Would be great to have the new Twitter icon included. Please give this one the green light! @colebemis @ashygee

@adammoisa
Copy link

+1

@Exetric Exetric closed this by deleting the head repository Oct 4, 2024
@5d5f8a0
Copy link

5d5f8a0 commented Oct 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarazinsfuss zarazinsfuss zarazinsfuss left review comments

@NotReeceHarris NotReeceHarris NotReeceHarris approved these changes

@colebemis colebemis Awaiting requested review from colebemis colebemis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Exetric @zarazinsfuss @terrablue @ryandotfurrer @karsa-mistmere @NicolaCocozza @yurist38 @adammoisa @5d5f8a0 @NotReeceHarris