Adds Various Icons #46
Conversation
|
Not sure how to add a new category to the site, so identity icons currently don't show. |
|
@kurisubrooks add category to |
|
Perfect! Thanks @alexantr |
icons/core/file-text.svg
Outdated
| <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"> | ||
| <path d="M13 2H6a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V9z" fill="none" stroke="#000" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"/> | ||
| <polyline points="13 2 13 9 20 9" fill="none" stroke="#000" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"/> | ||
| <line x1="16.2" y1="17.87" x2="7.8" y2="17.87" fill="none" stroke="#000" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"/> |
There was a problem hiding this comment.
Rounded coordinates will be nicely
<line x1="16" y1="18" x2="8" y2="18" .../>
<line x1="16" y1="14" x2="8" y2="14" .../>
There was a problem hiding this comment.
Oh sure. I just align items to the absolute center of the artboard once i'm done, but i'll update this if it doesn't look too bad.
There was a problem hiding this comment.
Yeah wow, never realised what a distance it made! Stunning....
|
Thanks for doing this @kurisubrooks! I'm going to wait until I finish the contribution instructions before I merge anything. |
|
@kurisubrooks How did you find that link to the Netlify deploy preview? |
|
@colebemis It's linked to the Netlify GitHub statuses. |
|
Oh, wow. That's cool! |
|
@kurisubrooks Can you remove the code, file and gender nonbinary icon from the PR? There is already one in feather icons
Gender female icon
Gender male iconCan you increase the size of the icon?
All these icons need to have a minimum of 2px of spacing around the icon
|
No. It can be broken case-by-case as say #171, and it's 1px at least for around the icon. |
Yes, all 4 icons which I have mentioned inside the table have different spacing. |
|
They only need at least 1px. |
|
Why did you close, @kurisubrooks ? |
|
The contents of the PR were fine and met the standards when it was submitted but nothing ever came from it and turned stale, so.... anyways this was made a long time ago, and I have no interest in updating it. If you'd like, please feel free to take the contents of this PR, fix it up as per the suggestions and resubmit :) |
|
May we add them to @featherity as well? :) |
|
@locness3 Haha I'm @ericfennis ;) |
Added File-Text (#23)
Added Code (#24)
Added Gender/Identity/Sexuality (#27)
Added Language (#36)
Added Half and Full Stars (#48)
Added Package Lock (for NPM 5+)