-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Icon truck
was updated and icons bike
, bus
, car
and taxi
were added
#789
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
Branches 3 3
=========================================
Hits 34 34 Continue to review full report at Codecov.
|
@ahtohbi4 These icons are 🔥 |
Tried copying the svg for car into a small project and found it rendered with thicker than anticipated lines. Not sure if this is a browser thing but wanted to post an example of what I am getting: codeCustomers<li class="nav-item">
<a class="nav-link active" href="#">
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-user">
<path d="M20 21v-2a4 4 0 0 0-4-4H8a4 4 0 0 0-4 4v2"></path>
<circle cx="12" cy="7" r="4"></circle>
</svg>
Customers
</a>
</li> Vehicles<li class="nav-item">
<a class="nav-link active" href="#">
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
<path d="M14 16H9m10 0h3v-3.15a1 1 0 00-.84-.99L16 11l-2.7-3.6a1 1 0 00-.8-.4H5.24a2 2 0 00-1.8 1.1l-.8 1.63A6 6 0 002 12.42V16h2"></path>
<path d="M6.5 19a2.5 2.5 0 100-5 2.5 2.5 0 000 5zM16.5 19a2.5 2.5 0 100-5 2.5 2.5 0 000 5z"></path>
</svg>
Vehicles
</a>
</li>
|
Ok see the difference now - needed to add the class == "feather" . With that change got the desired results. Perhaps we should include this in the commit? |
Just saying, all these icons except taxi are available at @lucide-icons :P |
Before:
Old icon
track
.After:
track
was updated andbike
,bus
,car
andtaxi
were added.