Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Icon truck was updated and icons bike, bus, car and taxi were added #789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahtohbi4
Copy link
Contributor

Before:

Old icon track.

Снимок экрана 2019-11-29 в 18 07 54

After:

  1. icon track was updated and
  2. icons bike, bus, car and taxi were added.

Снимок экрана 2019-11-29 в 18 11 06

@ahtohbi4 ahtohbi4 mentioned this pull request Nov 29, 2019
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #789   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...c4f5de6. Read the comment docs.

@locness3
Copy link

locness3 commented Dec 4, 2019

@colebemis ?

@jletey jletey mentioned this pull request Jan 14, 2020
@ericfennis
Copy link

@ahtohbi4 These icons are 🔥
If like to contribute, maybe you want to joins us at https://github.com/featherity/featherity and open this PR there 😁

@jtroussard
Copy link

Tried copying the svg for car into a small project and found it rendered with thicker than anticipated lines. Not sure if this is a browser thing but wanted to post an example of what I am getting:

image

code

Customers

<li class="nav-item">
  <a class="nav-link active" href="#">
    <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor"
      stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-user">
      <path d="M20 21v-2a4 4 0 0 0-4-4H8a4 4 0 0 0-4 4v2"></path>
      <circle cx="12" cy="7" r="4"></circle>
    </svg>
    Customers
  </a>
</li>

Vehicles

<li class="nav-item">
    <a class="nav-link active" href="#">
    <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
        <path d="M14 16H9m10 0h3v-3.15a1 1 0 00-.84-.99L16 11l-2.7-3.6a1 1 0 00-.8-.4H5.24a2 2 0 00-1.8 1.1l-.8 1.63A6 6 0 002 12.42V16h2"></path>
        <path d="M6.5 19a2.5 2.5 0 100-5 2.5 2.5 0 000 5zM16.5 19a2.5 2.5 0 100-5 2.5 2.5 0 000 5z"></path>
    </svg>
      Vehicles
    </a>
</li>
  • Windows 10
  • Chrome Version 89.0.4389.114 (Official Build) (64-bit)

@jtroussard
Copy link

Tried copying the svg for car into a small project and found it rendered with thicker than anticipated lines. Not sure if this is a browser thing but wanted to post an example of what I am getting:

image

code

Customers

<li class="nav-item">
  <a class="nav-link active" href="#">
    <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor"
      stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-user">
      <path d="M20 21v-2a4 4 0 0 0-4-4H8a4 4 0 0 0-4 4v2"></path>
      <circle cx="12" cy="7" r="4"></circle>
    </svg>
    Customers
  </a>
</li>

Vehicles

<li class="nav-item">
    <a class="nav-link active" href="#">
    <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
        <path d="M14 16H9m10 0h3v-3.15a1 1 0 00-.84-.99L16 11l-2.7-3.6a1 1 0 00-.8-.4H5.24a2 2 0 00-1.8 1.1l-.8 1.63A6 6 0 002 12.42V16h2"></path>
        <path d="M6.5 19a2.5 2.5 0 100-5 2.5 2.5 0 000 5zM16.5 19a2.5 2.5 0 100-5 2.5 2.5 0 000 5z"></path>
    </svg>
      Vehicles
    </a>
</li>
  • Windows 10
  • Chrome Version 89.0.4389.114 (Official Build) (64-bit)

Ok see the difference now - needed to add the class == "feather" . With that change got the desired results. Perhaps we should include this in the commit?

image

@locness3
Copy link

Just saying, all these icons except taxi are available at @lucide-icons :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants