Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'swords' icon #823

Closed
wants to merge 3 commits into from
Closed

feat: Add 'swords' icon #823

wants to merge 3 commits into from

Conversation

lukaschneider
Copy link

Closes #220

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #823 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #823   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91118a6...c4dfeab. Read the comment docs.

aFINKndreas
aFINKndreas previously approved these changes Jan 27, 2020
Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really look like Feather.
And we don't have a sword icon already, so this isn't much logical. Don't think only about your use case, but also to other people's

@lukaschneider
Copy link
Author

It doesn't really look like Feather.
And we don't have a sword icon already, so this isn't much logical. Don't think only about your use case, but also to other people's

don't know what u mean by it doesn't look feather to you... think it fits pretty well and followed the style guide :)

@moeenio
Copy link

moeenio commented Jan 29, 2020

Ok, but maybe make the swords look like the sword, this one looks better.
Or ask the experts @johnletey @ahtohbi4 😉

@jletey
Copy link

jletey commented Jan 29, 2020

Or ask the experts @johnletey @ahtohbi4 😉

Thanks for the kind words @locness3 😊

Ok, but maybe make the swords look like the sword, this one looks better.

I agree, the thickness of the swords are just too big for me, I prefer the sword.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Sword/swords
4 participants