-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fails hooks wrong return with around #709
Comments
feathers-hooks-common currently does not support around hooks, yet. There's no |
That also sir, but now even using in a normal hook, for example the preventChanges hook modify the context so then the feathers complains with a nasty error. Maybe there is other shooks that modify the context so will happen the same error. |
I've released around hooks are on the line and will come in a future release soon. |
doesnt look like this hook works with the around hook see :feathersjs-ecosystem/feathers-hooks-common#709
all this hooks fails if you use an around hook, why ? because this lib is modifying the context and feathers don't want that.
this should be avoid :
return {...context, data}
that spread fails as feathers detect the original hook changes
The text was updated successfully, but these errors were encountered: