Throw an error when using an incompatible version of Feathers (#66)

feathersjs · Aug 21, 2018 · 546d582 · 546d582
1 parent adebe75
commit 546d582
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 0 deletions.
diff --git a/packages/primus/lib/index.js b/packages/primus/lib/index.js
@@ -13,6 +13,10 @@ module.exports = function (config, configurer) {
     const app = this;
     const getParams = spark => spark.request.feathers;
 
+    if (!app.version || app.version < '3.0.0') {
+      throw new Error('@feathersjs/primus is not compatible with this version of Feathers. Use the latest at @feathersjs/feathers.');
+    }
+
     const done = new Promise(resolve => {
       Proto.mixin({
         listen (...args) {

diff --git a/packages/primus/package-lock.json b/packages/primus/package-lock.json
diff --git a/packages/primus/package.json b/packages/primus/package.json
@@ -58,6 +58,7 @@
     "@feathersjs/commons": "^1.0.0",
     "@feathersjs/express": "^1.0.0-pre.3",
     "@feathersjs/feathers": "^3.0.0-pre.3",
+    "feathers": "^2.2.3",
     "feathers-memory": "^1.0.0",
     "istanbul": "^1.1.0-alpha.1",
     "lodash": "^4.0.1",

diff --git a/packages/primus/test/index.test.js b/packages/primus/test/index.test.js
@@ -66,6 +66,17 @@ describe('@feathersjs/primus', () => {
     assert.equal(typeof require('../lib'), 'function');
   });
 
+  it('throws an error when using an incompatible version of Feathers', () => {
+    const oldFeathers = require('feathers');
+
+    try {
+      oldFeathers().configure(primus());
+      assert.ok(false, 'Should never get here');
+    } catch (e) {
+      assert.equal(e.message, '@feathersjs/primus is not compatible with this version of Feathers. Use the latest at @feathersjs/feathers.');
+    }
+  });
+
   it('runs primus before setup (#131)', done => {
     let counter = 0;
     const app = feathers()