fix(authentication-oauth): OAuth redirect lost sometimes due to sessi…

…on store race (#2514) (#2515)
feathersjs · Jan 6, 2022 · 67a7e31 · 67a7e31
1 parent 1c63e6b
commit 67a7e31
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/authentication-oauth/src/express.ts b/packages/authentication-oauth/src/express.ts
@@ -57,7 +57,13 @@ export default (options: OauthSetupSettings) => {
       req.session.redirect = redirect as string;
       req.session.query = query;
 
-      res.redirect(`${path}/connect/${name}?${qs.stringify(query as any)}`);
+      req.session.save((err: any) => {
+        if (err) {
+          res.status(500).send(`Error storing session: ${err}`);
+        } else {
+          res.redirect(`${path}/connect/${name}?${qs.stringify(query as any)}`);
+        }
+      });
     });
 
     authApp.get('/:name/callback', (req: any, res: any) => {