fix(authentication-client): Allow to abort fetch (#3310)

feathersjs · Nov 27, 2023 · ff3e104 · ff3e104
1 parent 0cbdb03
commit ff3e104
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/docs/api/client/rest.md b/docs/api/client/rest.md
@@ -132,13 +132,13 @@ const controller = new AbortController()
 
 app.configure(restClient.fetch(fetch))
 
-const promise = app.service('messages').get(1, {
+app.service('messages').get(1, {
   connection: {
     signal: controller.signal
   }
 })
 
-promise.abort()
+controller.abort()
 ```
 
 #### Superagent

diff --git a/packages/authentication-client/src/core.ts b/packages/authentication-client/src/core.ts
@@ -166,9 +166,10 @@ export class AuthenticationClient {
    *
    * @param force force reauthentication with the server
    * @param strategy The name of the strategy to use. Defaults to `options.jwtStrategy`
+   * @param authParams Additional authentication parameters
    * @returns The reauthentication result
    */
-  reAuthenticate(force = false, strategy?: string): Promise<AuthenticationResult> {
+  reAuthenticate(force = false, strategy?: string, authParams?: Params): Promise<AuthenticationResult> {
     // Either returns the authentication state or
     // tries to re-authenticate with the stored JWT and strategy
     let authPromise = this.app.get('authentication')
@@ -179,10 +180,13 @@ export class AuthenticationClient {
           return this.handleError(new NotAuthenticated('No accessToken found in storage'), 'authenticate')
         }
 
-        return this.authenticate({
-          strategy: strategy || this.options.jwtStrategy,
-          accessToken
-        })
+        return this.authenticate(
+          {
+            strategy: strategy || this.options.jwtStrategy,
+            accessToken
+          },
+          authParams
+        )
       })
       this.app.set('authentication', authPromise)
     }