-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service setup
called before app.io
instantiated
#131
Comments
I can confirm this. There is an easy fix with the only drawback that the service event handlers aren't set up in the configuration function but I don't think that would be an issue. I'll land the fix tonight and make a 1.1.0-pre.0 release that you can use. |
Run Socket configurations before service setup (#131)
Sorry, took a little longer but the issue should be fixed in version 1.1.0-pre.0 which is available on NPM. |
Great! Thanks for the fix. Big fan of feathers (come from Sails JS), would be happy to contribute in future. |
Awesome! Any contributions are welcome :) I'd still be curious in a Feathers vs Sails comparison. |
Sails is annoyingly opinionated in my experience. It is difficult to manage middle-ware properly. Sails-Waterline (database ORM) is fairly limited & slow in trying to support so many databases. Feathers elegantly bridges the gap, is lightweight & easily customizable. I am currently building a fresh mongodb service - one that supports query criteria such as |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs. |
I need access to
io
in an servicesetup()
method. This is instantiated in thefeathers.socketio()
configuration function. However, testing seems to indicate that my servicessetup()
method is being called before the socketio configuration function.Here's my usage:
The text was updated successfully, but these errors were encountered: