Todo example - getById() with String

[tylorr]

I was playing around with the todo example and I found a little bug. When I try to access this url: /todos/0 I get an error message saying Todo not found. (And I know there is a todo with id 0).

I discovered that the TodoStore.Get() method receives the id as a string then passes it along to the TodoStore.getById() method which compares the passed in id to the ids in the todos list using the === operator. Since the ids stored in the todos list are numbers and do not match the type of the passed in string, the comparison fails.

The get method is never used in the todos example, so it probably never showed up.

Some possible solutions are to convert the string to a number before passing it to getById or use the == operator so that it will not check type as well.

[tylorr]

Further investigation reveals that the get method should probably be receiving the id as a number, like update and remove does.

[daffl]

Thanks for catching that! I changed the === in the example to ==. I'm wondering why it doesn't get it as an actual number though (especially if update and remove get it as a number).

[daffl]

Upon a little further investigation I think the conversion needs to be done on the service level (for example with feathers-hooks) since in many cases the id isn't an actual number. Closing this issue but still open for other suggestions of course.

[Glavin001]

the conversion needs to be done on the service level (for example with feathers-hooks) since in many cases the id isn't an actual number.

Agreed. feathers-hooks to the rescue!

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.