Explicit authentication for emitting messages but not for listening

[knappdev]

Steps to reproduce

REST API works with one time authentication. But socket needs authentication everytime

import socketio from 'feathers-socketio/client';

this.app = feathers()
.configure(socketio(socket))
.configure(hooks())
.configure(authentication({
storage: AsyncStorage // To store our accessToken
}));
app.io.emit('messages::create', {
"text": "I really have to iron"
}, (error, message) => {
console.log('Todo created', message);
});

emit results in no output as socket is not explicitly authenticated

Expected behavior

we can listen to server message without explicit authentication. shouldn't the behaviour be same for both emitting and listening to messages

Actual behavior

console.: Todo created undefined

React Native Version:0.43.4

[daffl]

If you console.log(error) instead of the message you will see that you get the not authenticated error.

This is exactly the same call that the client service using this.app.service('messages').create({ text }).then(message => {}).catch(error => {}) does internally (it just converts the callback into a Promise).

[knappdev]

@daffl I agree. As you said I am getting Not Authenticated error. But the issue I want to point out is that why we can receive messages without authenticating the socket?

[marshallswain]

Because you need to filter messages on the server. There are so many different types of auth implementations that it's kinda impossible to provide a basic setup out of the box.

https://docs.feathersjs.com/api/events.html#event-filtering

[knappdev]

@marshallswain thanks for pointing that out. Then this behavior is as per implementation.

[daffl]

As @marshallswain pointed out, you have to explicitly add event filtering. We are working on improving this (see #388 (comment)) but for now this is indeed how it is intended. Going to close this issue.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.