Callbacks not required. Log any errors for the developer. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,18 @@ exports.setupMethodHandler = function setupMethodHandler(emitter, params, servic | |||
| if(typeof args[position] === 'function') { | |||
| args.splice(position, 0, {}); | |||
| } | |||
|
|
|||
| // If no callback was provided... | |||
| if (typeof args[args.length - 1] !== 'function') { | |||
There was a problem hiding this comment.
It should be possible to fire back an error event (or something similar) like emitter.emit('error', err).
|
Is it ok if we close this one and fix everything in #113 instead? |
|
Sure thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #96 . This makes callbacks optional for all service methods. If no callback is provided, one is added in commons.js. If there is an error, it will be logged to the server console in this format:
For example: