Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future warnings #693

Closed
solegalli opened this issue Sep 12, 2023 · 5 comments
Closed

future warnings #693

solegalli opened this issue Sep 12, 2023 · 5 comments

Comments

@solegalli
Copy link
Collaborator

List of future pandas warnings

c:\users\sole\documents\repositories\feature_engine\feature_engine\creation\math_features.py:212: FutureWarning: The provided callable <function sum at 0x0000016E1CA6D090> is currently using Series.sum. In a future version of pandas, the provided callable will be used directly. To keep current behavior pass 'sum' instead.
@glevv
Copy link
Contributor

glevv commented Sep 15, 2023

Connected to this
pandas-dev/pandas#53425

I think we can easily suppress this warning or not so easily bump pandas version.

We should also add information to this transformer, that same numpy and pandas functions could lead to different results (this is why they raise this warning). For example, np.std has ddof=0 while Series.std() has ddof=1

@olikra
Copy link
Contributor

olikra commented Jun 26, 2024

I sorted out the > 3000 warning messages of a complete pytest-run. Most of them ('SkipTestWarning', 'UserWarning', 'ConvergenceWarning', 'RuntimeWarning') can be irgnored by now to get a better view whats relevant.

In the feature-engine code itself we have to take care for:

  • FutureWarning 24 issues
  • DeprecationWarnings 2 issues
  • PytestReturnNotNoneWarning 3 issues

For details look into this file:
pytest_warnings.csv

In #774 I already worked on math_features - so it makes sense for me taking care of it. The rest needs to get sorted out as well cause we saw last week what happens ignoring / not seeing this warnings(#772).

@solegalli
Copy link
Collaborator Author

Thank you @olikra That would be great!

@solegalli
Copy link
Collaborator Author

Hey @olikra

Thank you so much for your work on the repo. I've got a quick question:

Did you take care of all the warnings on #777 ?

@solegalli
Copy link
Collaborator Author

closed in #781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants