Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy2 0 0 updates np.Inf vs np.inf #772

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

olikra
Copy link
Contributor

@olikra olikra commented Jun 17, 2024

Update tests for compatibility of numpy2_0_0 regarding np.Inf vs. np.inf

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (5f2bf8b) to head (77564f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         107      107           
  Lines        4283     4283           
  Branches      854      854           
=======================================
  Hits         4177     4177           
  Misses         62       62           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olikra
Copy link
Contributor Author

olikra commented Jun 17, 2024

@solegalli I assume you have to merge these changes into base branch to retest the other open pulls...

@solegalli solegalli merged commit 8cfab26 into feature-engine:main Jun 19, 2024
10 checks passed
@solegalli
Copy link
Collaborator

Thank you @olikra ! It's the never-ending story with the updates from numpy, pandas and sklearn.

@olikra olikra mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants