Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing_only init param to all imputers. missing_only is used in combination w/ the variables param. #698

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add missing_only init param to all imputers. missing_only is used in combination w/ the variables param. #698

wants to merge 20 commits into from

Commits on Sep 18, 2023

  1. initial commit. add 'missing_only' to BaseImputer init

    @Morgan-Sell
    Morgan-Sell committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    16abaaf View commit details
    Browse the repository at this point in the history

  2. create find_variables_with_missing_values() and unit test. unit test … 

    …passed.
    @Morgan-Sell
    Morgan-Sell committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    13a554f View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. create unit test for BaseImputer missing_only and add BaseImputer to … 

    …imputation __init__.py
    @Morgan-Sell
    Morgan-Sell committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    2c0d80b View commit details
    Browse the repository at this point in the history

  2. add 'variables' param to find_varibles_with_missing_vlaues and approp… 

    …riately revise unit test
    @Morgan-Sell
    Morgan-Sell committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    99a1567 View commit details
    Browse the repository at this point in the history

  3. add find_variables_with_missing_values to ArbitraryNumberImputer

    @Morgan-Sell
    Morgan-Sell committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    25726fb View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. create test_transformation_when_missing_only_is_true. all arbitrary t… 

    …ests pass
    @Morgan-Sell
    Morgan-Sell committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d8d8516 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. add find_variables_with_missing_values and docstring to CategoricalIm… 

    …puter class
    @Morgan-Sell
    Morgan-Sell committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    495645d View commit details
    Browse the repository at this point in the history

  2. add test_transformation_when_missing_only_is_true to CategoricalEncod… 

    …er class. Add missing_only param to CategoricalEncoder __init__. All CategoricalEncoder tests pass.
    @Morgan-Sell
    Morgan-Sell committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e8939f4 View commit details
    Browse the repository at this point in the history

  3. add test to ensure variables without missing values are not saved/tra… 

    …nsformed
    @Morgan-Sell
    Morgan-Sell committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c49c720 View commit details
    Browse the repository at this point in the history

  4. add test to ensure variables without missing values are not saved/tra… 

    …nsformed
    @Morgan-Sell
    Morgan-Sell committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    39123e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. fix errors discovered by Profesora Che ;)

    @Morgan-Sell
    Morgan-Sell committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    7e69fa8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. change find_variables_with_missing_values() to find_numerical_variabl… 

    …es_with_missing_values().
    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e4f6e03 View commit details
    Browse the repository at this point in the history

  2. create test_find_categorical_variables_with_missing_values()

    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5d9392f View commit details
    Browse the repository at this point in the history

  3. CategoricalImputer is raising an error. Need to discuss the interacti… 

    …on between 'ignore_format' and 'missing_only'
    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8336751 View commit details
    Browse the repository at this point in the history

  4. change order if if/else in ArbitraryImputer class

    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    42af407 View commit details
    Browse the repository at this point in the history

  5. create test_find_all_variables_with_missing_values()

    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b0036c8 View commit details
    Browse the repository at this point in the history

  6. add param and logic to EndTailImputer. still need to create unit test.

    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b803824 View commit details
    Browse the repository at this point in the history

  7. create EndTailImputer() unit test. tests passed.

    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    7b57a07 View commit details
    Browse the repository at this point in the history

  8. add missing_only logic to MeanMedianImputer(). create unit tests. tes… 

    …ts passed.
    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    a8f033a View commit details
    Browse the repository at this point in the history

  9. add 'missing_only' logic to RandomSampleImputer(). create unit test. … 

    …tests passed.
    @Morgan-Sell
    Morgan-Sell committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8c69b73 View commit details
    Browse the repository at this point in the history