Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base_imputer.py #813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Astha0024
Copy link

removing infer because it changed manually converted object columns back to int or float

removing infer because it changed manually converted object columns back to int or float
@solegalli
Copy link
Collaborator

Hi @Astha0024 thanks for the PR.

I remember vaguely adding the infer recently due to some pandas upgrade or something, By removing it, other tests fail.

What's the issue that you are having? could you add an example?

@Astha0024
Copy link
Author

So sometimes a column that could be inferred at numerical needs to be cast to object type for example : number of bathrooms in a house. Then when we pass it through this transformation, the infer converts it back to int and then we can't run encoding on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants