Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New board and background #385

Merged
merged 3 commits into from
Oct 16, 2018
Merged

New board and background #385

merged 3 commits into from
Oct 16, 2018

Conversation

ParmuzinAlexander
Copy link
Contributor

No description provided.

@OlivierBlanvillain OlivierBlanvillain mentioned this pull request Oct 6, 2018
@zsalch
Copy link
Contributor

zsalch commented Oct 11, 2018

@featurecat @OlivierBlanvillain
I think that in order to demo and guide users to use the new Theme, we should include an optional Theme when releasing the new version. What do you think?
@ParmuzinAlexander
If so, could you like to provide an extra background, board and stone images that you like?

@OlivierBlanvillain
Copy link
Contributor

@zsalch Sounds good! Should these additional images be added on top of the your theme PR?

@ParmuzinAlexander
Copy link
Contributor Author

You can add all images from https://github.com/ParmuzinAlexander/go-themes to Lizzie\theme\custom
Also need to change default "shadow-size": 55
Default for custom theme "solid-stone-indicator": true, black1.png, white1.png, background2.png, board1.png
Sorry I don't know how make pull request.

@zsalch
Copy link
Contributor

zsalch commented Oct 11, 2018

@ParmuzinAlexander
Thanks. I will add to my theme PR.
But I don't know what the name is, can you give them a proper name?

@OlivierBlanvillain
Copy link
Contributor

OlivierBlanvillain commented Oct 11, 2018

@zsalch Maybe you could also include in the Sabaki images (with proper attribution)? As long as it's not the default, I think they would be good to have!

@ParmuzinAlexander
Copy link
Contributor Author

@zsalch
Theme name? If use one folder for everything images it will be easier to customization. Complete theme like "sabaki", "photorealistic" this is a step backwards.
Now "assets" and "theme" they have the same functionality. It would be logical remove "assets" and use only "theme" folder (contains all the pictures.). And theme.txt transfer inside "ui" config.txt.

@zsalch
Copy link
Contributor

zsalch commented Oct 12, 2018

@ParmuzinAlexander
I mean, can you name your theme that includes you provided the images?

@ParmuzinAlexander
Copy link
Contributor Author

@zsalch
Yasnaya

@zsalch
Copy link
Contributor

zsalch commented Oct 14, 2018

@ParmuzinAlexander
I guess what you mean is that all the image files are placed in the theme folder, and the corresponding image is set in the theme.txt, such as yasnaya.txt, and the corresponding theme is specified as 'yasnaya ' in the config.txt file.
I want to know what is the advantage of this approach over the use of separate folder. I guess is it easy to maintain image files?

@ParmuzinAlexander
Copy link
Contributor Author

@zsalch
If user does not like some detail example background, it can change 1 character in config.txt background3.png->background1.png without copying and replacing the real file. All files weigh only 1.4 Mb.
And I don't suggest using theme.txt or yasnaya.txt need just setting what texture to use in config.txt.

@OlivierBlanvillain
Copy link
Contributor

I agree with you @ParmuzinAlexander, I feel that only having to update config.txt makes things simpler...

@zsalch
Copy link
Contributor

zsalch commented Oct 14, 2018

The new Theme logic supports two ways for change option.
You can ignore the theme.txt and directly change option in the config.txt.

@OlivierBlanvillain
Copy link
Contributor

OlivierBlanvillain commented Oct 16, 2018

Let's merge this for now and continue the discussion on #378. @ParmuzinAlexander Thanks!

@OlivierBlanvillain OlivierBlanvillain merged commit 4dbf54e into featurecat:next Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants