Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: Display latest stone for ghost dead stone #401

Merged
merged 3 commits into from
Nov 3, 2018
Merged

fixed: Display latest stone for ghost dead stone #401

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71701e0
Display latest stone for ghost dead stone
Oct 14, 2018
b27c6d0
Fixed stone double shadow when branch
Oct 24, 2018
c64887c
Merge branch 'next' into next_ghost
zsalch Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/featurecat/lizzie/gui/BoardRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,8 @@ private void drawBranch() {

for (int i = 0; i < Board.BOARD_SIZE; i++) {
for (int j = 0; j < Board.BOARD_SIZE; j++) {
if (Lizzie.board.getData().stones[Board.getIndex(i, j)] != Stone.EMPTY) continue;
// Display latest stone for ghost dead stone
// if (Lizzie.board.getData().stones[Board.getIndex(i, j)] != Stone.EMPTY) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove the line and don't put a comment...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently some test is ok, but has not more tests. I want to temporarily reserve it so that can suggest changes here when there is a problem.
Of course, I'm ok with remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. So you propose to keep it commented out until we are sure that it doesn't break something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change can solve some problems, but it also changes the display of the stones. I think we should be cautious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed a new change for fix the stone double shadow issue when branch

if (branch.data.moveNumberList[Board.getIndex(i, j)] > maxBranchMoves()) continue;

int stoneX = scaledMargin + squareLength * i;
Expand Down