Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hopefully fix hang-up that was reported in #777 and #780 #782

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Hopefully fix hang-up that was reported in #777 and #780 #782

wants to merge 4 commits into from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Oct 15, 2020

Ensure some doubtful methods to be called in EDT.

ref.
#777 (comment)
#780 (comment)

@hope366
Copy link

hope366 commented Oct 15, 2020

I just applied the second PR.
The first PR alone seemed to solve the problem, but does the second PR give you even more stability?
In any case, thank you for demonstrating excellent PR.

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Oct 24, 2020
Merge featurecat#782
9b65032
@kaorahi
Copy link
Contributor Author

kaorahi commented Nov 16, 2020

In my environment, Lizzie shows an empty window instead of the alert dialog "Lizzie requires version 0.15 or later of Leela Zero for analysis" if I set leela_gtp -g as the default engine after a628068. c500a89 fixes this.

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Nov 18, 2020
Merge featurecat#782 again for the additional fix
669482c
@kaorahi kaorahi mentioned this pull request Nov 18, 2020
Open
@kaorahi kaorahi mentioned this pull request Dec 6, 2020
Open
kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Sep 12, 2021
Fixup to featurecat#834 for featurecat#782
8cb70c0
@kaorahi kaorahi mentioned this pull request Nov 3, 2021
Closed
@kaorahi
Copy link
Contributor Author

kaorahi commented May 10, 2022

I pushed 2ce1d7f to fix kaorahi#3 (flicker of ownership colors in auto-analysis), that occurs after d790275.

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request May 10, 2022
Merge featurecat#782 yet again for another fix
c293dd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaorahi @hope366