-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #423 (node blunder colors in the default theme) #802
base: master
Are you sure you want to change the base?
Conversation
I have been using lizzie with this PR for quite some time. |
thx. It seems broken for some reason. Please apply 64dc629 to fix it. When you test it, you need to delete (or rename) both files |
I found the above "some reason". The name of the default theme is inconsistent between Config.java ("default") and ConfigDialog.java ("Default" in English, or i18n names in other languages). So 64dc629 can fail in non-English environments. The correct fix should be cd14ee8. Namely, we do not need to check the default theme here because we never touch cd14ee8 should work when all the following conditions are satisfied.
|
I'm afraid most users may not notice the feature #413 because of the issue #423. This PR applies the proposed parameters in #423 (comment) if they are empty. It works only once so that users can still set them empty again if they like.
related: #800 #801