Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of small fixes 001 #819

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

toomasr
Copy link
Contributor

@toomasr toomasr commented Nov 25, 2020

As I was analysing a game after a long time with KataGo I noticed that one of the settings isn't saved. There was a saving functionality missing in one of the listeners and then I added that. This is this commit - a38b127

On top of that I thought I'll also cherry pick some small useful fixes whether for users or for developers that are small enough for a quick review.

@kaorahi
Copy link
Contributor

kaorahi commented Nov 28, 2020

Hi, @toomasr san. Thanks for your fixes.

I noticed that ConfigDialog.java was modified after mvn package. This is very inconvenient in future developments. Though I am not an official staff of this project at all, can I ask you to keep the standard style of the project? (Or, it would be better to delete the empty else and these comment lines.)

diff --git a/src/main/java/featurecat/lizzie/gui/ConfigDialog.java b/src/main/java/featurecat/lizzie/gui/ConfigDialog.java
index 8f53bed1..dc598f7e 100644
--- a/src/main/java/featurecat/lizzie/gui/ConfigDialog.java
+++ b/src/main/java/featurecat/lizzie/gui/ConfigDialog.java
@@ -1830,7 +1830,7 @@ public class ConfigDialog extends JDialog {
               resourceBundle.getString("LizzieConfig.title.engine"), "exe", "bat", "sh");
       chooser.setFileFilter(filter);
     } else {
-      //setVisible(false);
+      // setVisible(false);
     }
     chooser.setMultiSelectionEnabled(false);
     chooser.setDialogTitle(resourceBundle.getString("LizzieConfig.prompt.selectEngine"));
@@ -1931,9 +1931,9 @@ public class ConfigDialog extends JDialog {
       Lizzie.initializeEngineManager();
     }
     try {
-      //if (Lizzie.engineManager != null) {
-        Lizzie.engineManager.refresh();
-      //}
+      // if (Lizzie.engineManager != null) {
+      Lizzie.engineManager.refresh();
+      // }
     } catch (JSONException e) {
       e.printStackTrace();
     } catch (IOException e) {

@toomasr
Copy link
Contributor Author

toomasr commented Nov 28, 2020

Thanks for the feedback. I've removed the dead lines.

@toomasr
Copy link
Contributor Author

toomasr commented Nov 28, 2020

@kaorahi what is the easiest way to contact you about general discussion on go software?

@kaorahi
Copy link
Contributor

kaorahi commented Nov 28, 2020

How about using issues of my GUI if it is not related to Lizzie?

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Dec 5, 2020
This was referenced Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants