Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/108 enhance validation rules op1 #109

Merged
merged 22 commits into from
Aug 25, 2022

Conversation

Elaine-Krauss-TCG
Copy link
Contributor

@Elaine-Krauss-TCG Elaine-Krauss-TCG commented Aug 24, 2022

#108

Updates the schema rules to match the specs as defined here

This repo also includes the repo patching script that I wrote a while back. I though a decent place for it would be the bin directory in the validator repo. (Note: it can be run from any directory) I added it to the sonar-cloud code coverage exclusions as testing a command line script would be very tricky.

Paired with App and API PR's

@Elaine-Krauss-TCG Elaine-Krauss-TCG changed the title Feature/108 enhance validation rules op1 [WIP] Feature/108 enhance validation rules op1 Aug 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
20.7% 20.7% Duplication

@mjtravers mjtravers changed the title [WIP] Feature/108 enhance validation rules op1 Feature/108 enhance validation rules op1 Aug 25, 2022
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. No additional changes needed.

@mjtravers mjtravers merged commit fc167da into develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants