Feature/75 Add boolean and date fields to validation #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjtravers
changed the title
|
SonarCloud Quality Gate failed. |
mjtravers
changed the title
mjtravers
changed the title
toddlees
requested changes
Jun 23, 2022
toddlees
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75
Code Review Note: The unit test code coverage is inaccurate. It looks like the fecfile_validate_js/src/index.ts file is not getting picked up in the coverage calculation. see report here Will look at that separate from this ticket.
Technical note: Due to errors being thrown by the ajv validation library when loading the ajv-formats extension, the "format": "date" property has been replaced by "pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}$", which performs the same string check