Refactor sorting of report code column on report list page

[mjtravers]

Business Reason

As a user viewing the Report list page, I want to be able to sort on report code labels.

Acceptance Criteria

When sorting the reports list table by report code, the rows sort properly

Tech Notes

Based on decisions from the 5/23 weekly dev meeting, the report code labels are to be stored in a Django model in the Django f3x_summaries app. The api will use the model table in its query sort for the reports table and also provide an endpoint for the front end to pull the labels via a REST endpoint.

Files of interest:

• https://github.com/fecgov/fecfile-web-api/blob/develop/django-backend/fecfiler/f3x_summaries/views.py#L18-L45
• https://github.com/fecgov/fecfile-web-app/blob/develop/front-end/src/app/shared/models/f3x-summary.model.ts#L81-L109
• https://github.com/fecgov/fecfile-web-app/blob/develop/front-end/src/app/reports/report-list/report-list.component.html#L62

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-324

[Elaine-Krauss-TCG]

On the back-end, every report has a Report Code that is a foreign key towards a table containing report codes and their corresponding labels. The sorting of reports factors these changes in.

On the front-end, the Report List component no longer relies on a locally defined list of report code labels but rather pulls labels from an API endpoint.

QA: The front-end includes new unit tests to cover a newly introduced pipe. The tests are passing cleanly

[WiseQA]

Put back into Code Review - the Unit Test needs to show Pass / Fail, like example was given. @toddlees assigned back

[Elaine-Krauss-TCG]

The unit tests do show that they passed? Right at the top on the page that I linked to before moving it to code review. Looking over the example given by Todd again, I still don't see a meaningful difference between what I did and what was done there by the person who handled that ticket.

[WiseQA]

Okay I am good with it - was just verifying - go ahead and move back to my bucket Elaine - Who did the CR ? *Shelly Wise* *QA/Test Engineer* *Tygart Technology* ***@***.*** ***@***.***>* *304-657-9070* *CMMI - ITIL - ISO 9001:2015 - Agile/SAFe*

…

On Mon, Jun 13, 2022 at 8:45 AM Elaine-Krauss-TCG ***@***.***> wrote: The unit tests do show that they passed? Right at the top on the page that I linked to before moving it to code review. Looking over the example <https://app.zenhub.com/workspaces/fecfile-online-619e578e68408b001c831251/issues/fecgov/fecfile-validate/4> given by Todd again, I still don't see a meaningful difference between what I did and what was done there by the person who handled that ticket. [image: image.png] <https://camo.githubusercontent.com/adf0ec6db174cd0312d5bdbc9212b849107bc2f3f603d77242042885e2c86040/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3632366162356538313339346163653634663865643635642f63323963306430342d373335382d346339652d383038612d373337373364343863666430> — Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW5PVCCQWLSQJUPGXRB3ZU3VO4UPVANCNFSM5WGR5JEA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[Elaine-Krauss-TCG]

Alternative link to the CircleCI Results

[WiseQA]

Verified unit test passed successfully, visual inspection.
QA review completed. Moved to Stage Ready.