Converted memo_code to boolean and added schema query param #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
toddlees
approved these changes
May 18, 2022
| @@ -38,6 +38,10 @@ def get_schema_name(self, data): | |||
| :py:function:`fecfile_validate.validate` that will | |||
| match a schema defined in the package | |||
| """ | |||
| request = self.context.get("request", None) | |||
| if request and request.query_params.get("schema"): | |||
| self.schema_name = request.query_params.get("schema") | |||
There was a problem hiding this comment.
this got me wondering if setting the schema name would impact subsequent requests. basically is a single serializer instance used in drf for each request. I ran a little test printing schema_name before and after we set it. It does not persist across requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app#230