Merge pull request #2098 from fecgov/feature/1481-front-end-pac-update

update front end generation of pac_jf_transfer_memo cpd
fecgov · Aug 9, 2024 · b0a1642 · b0a1642
2 parents 641072e + 1404602
commit b0a1642
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/front-end/src/app/shared/models/transaction-types/PAC_JF_TRANSFER_MEMO.model.spec.ts b/front-end/src/app/shared/models/transaction-types/PAC_JF_TRANSFER_MEMO.model.spec.ts
@@ -24,6 +24,6 @@ describe('PAC_JF_TRANSFER_MEMO', () => {
 
   it('#generatePurpotransaction.seDescription() should generate a string', () => {
     const descrip = transaction.transactionType?.generatePurposeDescription?.(transaction);
-    expect(descrip).toBe('Joint Fundraising Memo: Test Org');
+    expect(descrip).toBe('JF Memo: Test Org');
   });
 });
diff --git a/front-end/src/app/shared/models/transaction-types/PAC_JF_TRANSFER_MEMO.model.ts b/front-end/src/app/shared/models/transaction-types/PAC_JF_TRANSFER_MEMO.model.ts
@@ -15,9 +15,7 @@ export class PAC_JF_TRANSFER_MEMO extends SchATransactionType {
   override navigationControls = CHILD_CONTROLS;
 
   override generatePurposeDescription(transaction: SchATransaction): string {
-    return `Joint Fundraising Memo: ${
-      (transaction?.parent_transaction as SchATransaction).contributor_organization_name
-    }`;
+    return `JF Memo: ${(transaction?.parent_transaction as SchATransaction).contributor_organization_name}`;
   }
 
   getNewTransaction() {

diff --git a/front-end/src/app/shared/utils/unit-test.utils.ts b/front-end/src/app/shared/utils/unit-test.utils.ts
@@ -202,7 +202,7 @@ export const testScheduleATransaction = SchATransaction.fromJSON({
   contribution_date: '2022-08-11',
   contribution_amount: 1,
   contribution_aggregate: 2,
-  contribution_purpose_descrip: 'Joint Fundraising Memo: test',
+  contribution_purpose_descrip: 'JF Memo: test',
   aggregation_group: AggregationGroups.GENERAL,
   memo_code: true,
   donor_committee_fec_id: 'C00000000',