Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display hidden p-divider #2088

Closed
exalate-issue-sync bot opened this issue Aug 7, 2024 · 7 comments
Closed

Display hidden p-divider #2088

exalate-issue-sync bot opened this issue Aug 7, 2024 · 7 comments
Assignees
Labels

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Aug 7, 2024

Description: Where was the issue found: * Committee ID: C00100495 * Environment: STAGE / DEV * Browser: Chrome

Please describe the issue: Display the hidden p-dividers. The following pages will be affected by this change.

Committee Account Information Page

Select Committee Page

Register Committee Page

Security Notice Page

F24 -> add an independent expenditure page

F99

Print preview page

Confirm information page (under sign&submit)

Manage Users page

Loan agreement (third part of a loan from bank)

Approx. time the issue was found: 10:15 am on 08/07/2024

How to replicate the issue:

  1. Select one of the pages provided above.
  2. The lines are not displaying on the page (this is the bug)

Screenshots:

Below a couple of screenshots of pages (see list above) with hidden p-divider and lines not displaying.

image-20240807-163508.png

image-20240807-163404.png

Mitchell Jarrett Todd Lees Bug found during testing in Sprint 46. Ticket pointed as 3 points and added to Sprint Backlog for Sprint 46.

QA Notes

null

DEV Notes

null

Design

null

FECFILE-1518

Copy link
Author

Elaine Krauss commented: The PrimeNG p-divider component does not display. Some instances of p-divider’s have already been replaced with


components. The pull request for this ticket has replaced all remaining instances of components, which resolves this issue on all affected pages.

Example of an F99 form after the fix:

!image-20240808-181837.png|width=755,height=1067,alt="image-20240808-181837.png"!

Copy link
Author

Todd Lees commented: Passes CR moving to QA:

Example of lines showing up in account info page:

!image-20240808-212736.png|width=1192,height=610,alt="image-20240808-212736.png"!

Copy link
Author

Shelly Wise commented: QA review verified the lines were showing up on pages as denoted in description above.

After review with [~accountid:61b0b42cc510bc006b5c03ed] as UX there are two pages that have grayed box area that should only have the line under the sublabel and not within the grayed box area.

Pages to be corrected “Print preview” and “Confirm information”. Returning to in-progress for the lines to be removed within the “grayed box” areas.

!image-20240809-175833.png|width=847,height=608,alt="image-20240809-175833.png"!

!image-20240809-175900.png|width=542,height=421,alt="image-20240809-175900.png"!

[~accountid:61b0b42cc510bc006b5c03ed] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] [~accountid:712020:eaccd25d-427c-4e4d-a650-909ec0b31071] Returning to in-progress for the lines to be removed within the “grayed box” areas.

Copy link
Author

Elaine Krauss commented:


elements have been removed from the Print Preview and Report Submission - Email Confirmation pages.

The Print Preview page previously had a that was replaced with the offending


element, and the Report Submission - Email Confirmation page has had a
element since March.

[New PR|https://github.com//pull/2099/files]
[Previous PR|https://github.com//pull/2092]

Copy link
Author

Todd Lees commented: passes CR moving to QA

Copy link
Author

Shelly Wise commented: QA review verified with UX changes for the below page lines were corrected. The lines were removed within the “grayed box” areas.

!image-20240809-235443.png|width=1019,height=717,alt="image-20240809-235443.png"!

!image-20240809-235601.png|width=539,height=572,alt="image-20240809-235601.png"!

QA Review Completed. Moved to Stage Ready.

Copy link
Author

Sprint accepted by Paul Clark during sprint review on 8/20/2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant