Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1518 - Replace all P-Dividers #2092

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

Elaine-Krauss-TCG
Copy link
Contributor

Copy link
Contributor

@toddlees toddlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Who knows why the p-dividers went invisible. Who cares.

Lets get rid of the css for them in theme.css

also looks like i missed a page or two in the list i gave shelly. looks like the TransactionIndependentExpenditurePickerComponent has one that we'll want to convert as well

@Elaine-Krauss-TCG
Copy link
Contributor Author

Elaine-Krauss-TCG commented Aug 8, 2024

I like it. Who knows why the p-dividers went invisible. Who cares.

Lets get rid of the css for them in theme.css

also looks like i missed a page or two in the list i gave shelly. looks like the TransactionIndependentExpenditurePickerComponent has one that we'll want to convert as well

Ah, I searched for <p-divider> and I missed the one instance where a p-divider had a class. Fixed

Copy link

sonarcloud bot commented Aug 8, 2024

@toddlees toddlees merged commit 9999298 into develop Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants