Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to enter Transfer on Schedule A (Group F) #492

Closed
1 task
GreggMoreland opened this issue Aug 23, 2022 · 9 comments
Closed
1 task

Allow user to enter Transfer on Schedule A (Group F) #492

GreggMoreland opened this issue Aug 23, 2022 · 9 comments
Assignees

Comments

@GreggMoreland
Copy link

GreggMoreland commented Aug 23, 2022

Business Reason

As a Committee Administrator, I will be able to enter a ”Transfers” transaction on Schedule A of a Form 3X report so that I can accurately report on my committee's transactions.

Acceptance Criteria

Given I am a Committee Administrator editing an open Form 3X report
Then Add a new transaction
Then Click(open) on the "Transfer" Accordion link
Then I can enter a transaction with the type “Transfer"
Then I will be required to enter the following information (unless otherwise noted):


Contributor Contact

  • CONTRIBUTOR CONTACT TYPE (Read-only, INCLUDES LOOKUP)
    -- Committee Only
  • COMMITTEE NAME (Required)
  • COMMITTEE FEC ID (Required)

Address

  • STREET ADDRESS (Required)
  • APARTMENT, SUITE, ETC. (Optional)
  • CITY (Required)
  • STATE/PROVINCE (Required)
  • ZIP/POSTAL CODE (Required)

Contribution

  • DATE RECEIVED (Required)
  • MEMO ITEM (Optional)
  • CONTRIBUTION AMOUNT (Required)
    -- Note: AMOUNT can contain a negative value.
  • CONTRIBUTION AGGREGATE (Required)
    -- Amount Displayed will be the total of contributions that are:
    --- From the person (ENTITY)
    -- within Aggregation Group of "GENERAL"
    --- from January 1 of report year to the Contribution Date* of the transaction.
    --- *If there are two transactions with the same Contribution Date for the contributor, use date/time stamp transaction was created.

Additional information

  • CONTRIBUTION PURPOSE DESCRIPTION (Read-only, Optional)
  • NOTE OR MEMO TEXT (A/N-100, Optional)

Then I will be able to:

  • Save & add another
  • Save & view all transactions [will go to "Manage your transactions" Table]
  • Edit as needed
  • Cancel

And the transaction will be itemized upon saving with it's own line item on the *.fec file (SA12). (Dev note: All SA12 transactions are itemized regardless of amount).

Dev Note

Group F - Transfer Receipt.png

QA Notes

null

DEV Notes

null

Design

null

@AureliaKhorsand AureliaKhorsand added the UX/UI attention needed UX/UI tasks and/or redesign needed label Sep 8, 2022
@AureliaKhorsand AureliaKhorsand changed the title Allow user to enter Transfers on Schedule A (Group F) Allow user to enter Transfer on Schedule A (Group F) Sep 8, 2022
@AureliaKhorsand AureliaKhorsand removed the UX/UI attention needed UX/UI tasks and/or redesign needed label Sep 9, 2022
@AureliaKhorsand AureliaKhorsand self-assigned this Sep 14, 2022
@AureliaKhorsand AureliaKhorsand added UX/UI attention needed UX/UI tasks and/or redesign needed and removed UX/UI attention needed UX/UI tasks and/or redesign needed labels Sep 16, 2022
@toddlees toddlees self-assigned this Oct 20, 2022
@mjtravers
Copy link
Contributor

Some changes requested in CR. Sending back to In Progress.

@mjtravers
Copy link
Contributor

Passes CR. Sending to QA.

@WiseQA
Copy link

WiseQA commented Oct 31, 2022

QA review - Cancel button not selectable. Only buttons selectable "Save & add another Memo" and "Save & view all transactions".

image.png

@mjtravers @MitchellTCG - Cancel button should be selectable ? If so, need added to Acceptance Criteria and button fixed. Standing by for clarification.

Returned to "in-progress" for "Cancel" button.

@MitchellTCG
Copy link
Contributor

@WiseQA @toddlees @mjtravers
Re: Cancel button ...
Yes the Cancel button should work. I will update the ticket. Dev's please fix.

@toddlees
Copy link
Contributor

@WiseQA @MitchellTCG @mjtravers got a PR for it up now. It also removes the yellow/orange "Save & add another Memo" which is not supposed to be on this form #658

@mjtravers
Copy link
Contributor

Patch for cancel button passes CR. It also passes a quick smoke test on DEV. Sending to QA.

@WiseQA
Copy link

WiseQA commented Oct 31, 2022

QA review "Save & add another" button not displaying in Transfer Transaction page.

image.png

@mjtravers @toddlees @MitchellTCG - Returned to "In-progress" for "Save & add another" button fix.

@mjtravers
Copy link
Contributor

Button moved and code passes CR. Sending to QA.

@WiseQA
Copy link

WiseQA commented Nov 2, 2022

QA review verified "Save & add another" button is displaying and functional. Retested functionality of the buttons for Transfer transaction.

image.png

QA Review Completed. Moved to Stage Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants