Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/492 transfer #640

Merged
merged 28 commits into from
Oct 28, 2022
Merged

Feature/492 transfer #640

merged 28 commits into from
Oct 28, 2022

Conversation

toddlees
Copy link
Contributor

@toddlees toddlees commented Oct 24, 2022 •
edited
Loading

@Elaine-Krauss-TCG
Copy link
Contributor

Approved, linting and unit tests notwithstanding, of course.

@toddlees toddlees changed the title [WIP] Feature/492 transfer Feature/492 transfer Oct 27, 2022
mjtravers
mjtravers requested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for some thoughts about code organization. Great abstraction out of the form navigation. Makes me really want to the the form import controls abstracted out now in a big way

front-end/src/app/shared/models/transaction-navigation-controls.model.ts Outdated Show resolved Hide resolved
front-end/src/app/shared/interfaces/transaction-type.interface.ts Outdated Show resolved Hide resolved
front-end/src/app/shared/interfaces/transaction-type.interface.ts Outdated Show resolved Hide resolved
front-end/src/app/shared/models/transaction-types/TRANSFER.model.ts Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.0% 87.0% Coverage
5.4% 5.4% Duplication

@mjtravers mjtravers merged commit 4a4760c into develop Oct 28, 2022
@mjtravers mjtravers deleted the feature/492-transfer branch October 28, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjtravers mjtravers mjtravers approved these changes

@Elaine-Krauss-TCG Elaine-Krauss-TCG Elaine-Krauss-TCG approved these changes

@dheitzer dheitzer dheitzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toddlees @Elaine-Krauss-TCG @mjtravers @dheitzer