Solves stale committee data #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddlees
requested review from
mjtravers,
Elaine-Krauss-TCG and
sasha-dresden
mjtravers
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this by:
logging in before change -> selecting committee -> delete session cookie -> navigate to reports and get redirected to login -> login -> not asked to select committee (because account data is stale) -> got to reports page -> get 500 because session has no active commmittee
Tests fix by:
logging in after change -> select committee -> delete session cookeie -> navigate to reports and get redirected to login -> login -> asked to select committee -> got to reports page -> get reports