Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/66 2 #1770

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Feature/66 2 #1770

merged 4 commits into from
Mar 12, 2024

Conversation

sasha-dresden
Copy link
Contributor

Fixes to meet updated Reqs:

  • Form type' column should be populated with Form Name like on the 'Manage Reports' page. ex. "Form 24"
  • 'Report type' column should be populated with Name of the report like in the 'Type of report' column on the "Manage reports" page. ex. "APRIL 15 (Q1)"
  • Change the format of the Date from "2016-02-03" (YEAR-MONTH-DAY) to "01/01/2016" (MONTH/DAY/YEAR)

In order to setup the 'Report type' column I added a new abstract getter to the report class to be implemented in each Form class and then updated the 'Manage Reports' page to use this as the example shown for Form 24 was not reflected properly on the "Manage Reports" page. I only set this up for Form 24 and Form 3X as those were the only ones I had data for.

Copy link

sonarcloud bot commented Mar 12, 2024

@mjtravers mjtravers merged commit 6e8a0e6 into develop Mar 12, 2024
5 checks passed
@mjtravers mjtravers deleted the feature/66-2 branch March 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants