Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/354 #1838

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Feature/354 #1838

merged 8 commits into from
Apr 23, 2024

Conversation

dheitzer
Copy link
Contributor

@Elaine-Krauss-TCG
Copy link
Contributor

The splitting of names with included middle names doesn't seem to be working right.

Local:
image

DEV:
image

@dheitzer
Copy link
Contributor Author

The splitting of names with included middle names doesn't seem to be working right.

Local: image

DEV: image

@Elaine-Krauss-TCG this looks to be an issue with the data for this candidate:
https://fec-dev-api.app.cloud.gov/v1/candidate/S6MT00162/history/?api_key=DEMO_KEY

We're getting back

"name": "TESTER, R. JON",
"candidate_last_name": "TESTER",
"candidate_middle_name": null,
"candidate_first_name": "R.",

We're taking candidate_last_name and candidate_first_name since they are available for this record.

@lbeaufort do you have any thoughts about how we should handle this? Thanks.

@dheitzer
Copy link
Contributor Author

The splitting of names with included middle names doesn't seem to be working right.

Local: image

DEV: image

after discussing with @lbeaufort, it was determined that this is an upstream data issue and that we should move forward with this ticket while opening a ticket for analysis to openfec.

Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
37.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mjtravers mjtravers merged commit a3f4c46 into develop Apr 23, 2024
4 of 5 checks passed
@mjtravers mjtravers deleted the feature/354 branch April 23, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants