feature/1464 - Fix confirmation dialog getting activated multiple times when more than one table on page. #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: FECFILE-1464
The underlying problem was that the refactored Table component had a Confirmation Dialog inside of it. Which was fine if there was only ever a single table on the page or if you didn't want to style it. This was a problem for the Table List page as we had 3 tables on the page, leading to all three triggering an instance of the Table's Confirmation Dialog.
To fix this I removed the Confirmation Dialog from the Table and placed a default/fallback instance of the Confirmation Dialog at the top App level. Now, there would only be one instance. I also added a key to the Confirmation Dialog on the Table List page so it would specifically open that version, which has the correctly customized footer.