feature/1229 - Update filing frequency toggle to default based on the filing frequency of the committee #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy of the committee
toddlees
requested changes
Aug 28, 2024
| @@ -83,7 +83,7 @@ export class CreateF3XStep1Component extends DestroyerComponent implements OnIni | |||
| .pipe(takeUntil(this.destroy$)) | |||
| .subscribe(([committeeAccount, existingCoverage]) => { | |||
| this.committeeAccount = committeeAccount; | |||
| const filingFrequency = this.userCanSetFilingFrequency ? 'Q' : committeeAccount?.filing_frequency; | |||
| const filingFrequency = committeeAccount?.filing_frequency ?? 'Q'; | |||
There was a problem hiding this comment.
looks like the acs are a little more complicated:
if Filing Frequency = Q, A or T, system will default to 'Quarterly Reporting'
There was a problem hiding this comment.
Ah I see what you mean, we wouldn't want to set filingFrequency to 'T'. I updated this logic so now everything that isn't 'M' defaults to 'Q'. That way 'Q', 'A', and 'T' all go to 'Q', but also when it's undefined it goes to 'Q' as well.
sasha-dresden
force-pushed
the
feature/1229
branch
from
5b9f1cd
to
ed2d7f5
Compare
|
Elaine-Krauss-TCG
approved these changes
Sep 3, 2024
toddlees
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue FECFILE-1229