feature/1444 - Add ability to unamend an unmodified amendment #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddlees
requested changes
Aug 23, 2024
| @@ -107,6 +108,28 @@ export class ReportListComponent extends TableListBaseComponent<Report> implemen | |||
| }); | |||
| } | |||
|
|
|||
| public confirmUnamend(report: Report): void { | |||
There was a problem hiding this comment.
I'm not seeing a confirm dialog in the ticket. I think we need to leave this out.
There was a problem hiding this comment.
Took out confirm.
| .startUnamendment(report) | ||
| .pipe(take(1), takeUntil(this.destroy$)) | ||
| .subscribe(() => { | ||
| this.loadTableItems({}); |
There was a problem hiding this comment.
The ticket references a toast message. Probably need to add:
this.messageService.add({
severity: 'success',
summary: 'Successful',
detail: 'Report Unamended',
life: 3000,
});
There was a problem hiding this comment.
Added in toast.
| @@ -104,6 +104,10 @@ export class ReportService implements TableListService<Report> { | |||
| return this.apiService.post(`${this.apiEndpoint}/${report.id}/amend/`, {}); | |||
| } | |||
|
|
|||
| public startUnamendment(report: Report): Observable<string> { | |||
There was a problem hiding this comment.
I see we're following the pattern the amendment implementation set. What do you think of changing these two to promises?
public amend(report:Report): Promise<string> {
return getFirstValueFrom(this.apiService.post(...))
}
There was a problem hiding this comment.
Oh I just saw this one. Yea promises would make a lot more sense here.
sasha-dresden
force-pushed
the
feature/1444
branch
from
e7de8b8
to
76b74ef
Compare
sier processing
sasha-dresden
force-pushed
the
feature/1444
branch
from
869cfa0
to
57842d9
Compare
|
toddlees
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue FECFILE-1444
API PR PR1032