Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/328 django login-dot-gov django login dot gov #280

Merged
merged 24 commits into from
Jun 29, 2022
Merged

Feature/328 django login-dot-gov django login dot gov #280

merged 24 commits into from
Jun 29, 2022

Conversation

dheitzer
Copy link
Contributor

No description provided.

@dheitzer dheitzer changed the title Feature/109 django login dot gov [WIP] Feature/109 django login dot gov May 20, 2022
Elaine-Krauss-TCG
Elaine-Krauss-TCG approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@Elaine-Krauss-TCG Elaine-Krauss-TCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great 👍

@dheitzer dheitzer changed the title [WIP] Feature/109 django login dot gov Feature/109 django login dot gov Jun 16, 2022
mjtravers
mjtravers requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change please that I didn't think to mention earlier on code organization: Would you move the login-page.guard.ts into a newly created directory: src/app/shared/guards ?

toddlees
toddlees requested changes Jun 16, 2022
View reviewed changes
front-end/src/app/login/guards/login-page.guard.ts Outdated Show resolved Hide resolved
front-end/src/environments/environment.cloud.gov.dev.ts Outdated Show resolved Hide resolved
tasks.py Outdated Show resolved Hide resolved
@mjtravers mjtravers changed the title Feature/109 django login dot gov Feature/328 django login-dot-gov django login dot gov Jun 28, 2022
@dheitzer
Copy link
Contributor Author

This was addressed

@dheitzer dheitzer closed this Jun 28, 2022
@dheitzer dheitzer reopened this Jun 28, 2022
mjtravers
mjtravers requested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment about environment files for stage and prod needing the loginDotGov env vars as well.

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.1% 85.1% Coverage
0.0% 0.0% Duplication

@mjtravers mjtravers merged commit 02d324f into develop Jun 29, 2022
@mjtravers mjtravers deleted the feature/109-django-login-dot-gov branch June 29, 2022 15:08
@dheitzer dheitzer mentioned this pull request Jun 30, 2022
Merged
@dheitzer dheitzer restored the feature/109-django-login-dot-gov branch June 30, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjtravers mjtravers mjtravers approved these changes

@toddlees toddlees toddlees approved these changes

@Elaine-Krauss-TCG Elaine-Krauss-TCG Elaine-Krauss-TCG approved these changes

@lbeaufort lbeaufort Awaiting requested review from lbeaufort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dheitzer @mjtravers @toddlees @Elaine-Krauss-TCG