Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committee Detail Links #301

Merged
merged 7 commits into from
May 25, 2022
Merged

Conversation

toddlees
Copy link
Contributor

Issue: #130

On the Committee Details page, link buttons at the bottom will direct the user to their most recent F1 filing PDF or to the site where they can file a new F1.

To get the correct F1 pdf link, we check the realtime efile/filings/ endpoint. If a recent F1 is not found in that response, we check the filings/ endpoint which is updated nightly but retains older reports.

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.5% 86.5% Coverage
0.0% 0.0% Duplication

@toddlees toddlees changed the title [WIP] Committee Detail Links Committee Detail Links May 24, 2022
Copy link
Member

@lbeaufort lbeaufort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @toddlees!

@mjtravers mjtravers merged commit f28798f into develop May 25, 2022
@mjtravers mjtravers deleted the feature/130-committee-detail-links branch May 25, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants