Defect/365 istrusted logindotgov code error #388
Conversation
|
Do we know what's going on with the circleci test failure?
Edit: Seems to be working now! |
| this.store.dispatch(userLoggedInAction({ payload: userLoginData })); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we drop the use of cookies and use the ngrx store 100% or is the use of cookies required?
[googling around...]
I see that the CORS_ALLOW_CRENDENTIALS setting in Django may require the use of cookies. Is that what you found, David?
There was a problem hiding this comment.
@mjtravers well, the problem was that the server needs to send this data down to the client alongside a redirect. Because I couldn't use a JSON body in the redirect, I felt my only option was to pass them using cookies. This code then deletes the cookies once they are received following login.
There was a problem hiding this comment.
It actually does ultimately store the cookie data in the store UserLoginData object, but only receives it from the server via cookies. I'm open for any suggestions on how to send these from the server though if we want to use something else.
There was a problem hiding this comment.
That works for me. Thanks for the clarification
|
Kudos, SonarCloud Quality Gate passed! |
Nice catch. That was odd. I tried rerunning the build and it worked fine now. |
No description provided.